[SYSTEMDS-3931] Out-of-core right indexing operations#2351
Closed
janniklinde wants to merge 5 commits intoapache:mainfrom
Closed
[SYSTEMDS-3931] Out-of-core right indexing operations#2351janniklinde wants to merge 5 commits intoapache:mainfrom
janniklinde wants to merge 5 commits intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2351 +/- ##
============================================
+ Coverage 72.29% 72.31% +0.01%
- Complexity 46829 46879 +50
============================================
Files 1508 1510 +2
Lines 177638 177927 +289
Branches 34880 34937 +57
============================================
+ Hits 128430 128668 +238
- Misses 39511 39531 +20
- Partials 9697 9728 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM - thanks for the patch @janniklinde. During the merge I only resolved the merge conflicts and removed a few warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces out-of-core right indexing support. Note that because we forward aligned blocks, issues could occur with
OOCEvictionManager(evictions might happen based on the old stream, affecting the new output stream with the same block references). Similar issues could occur when having stackedCachingStreams.